Implement redirecting factories in mirrors.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to override [Element.computeType] because our
  * optimizers may look at its declared type.
@@ skipping 4164 matching lines @@
     handleInTryStatement();
     closeAndGotoExit(new HThrow(exception, isRethrow: true));
   }
 
   visitReturn(Return node) {
     if (identical(node.getBeginToken().stringValue, 'native')) {
       native.handleSsaNative(this, node.expression);
       return;
     }
     HInstruction value;
     if (node.isRedirectingFactoryBody) {

[karlklose, 2013/09/17 09:12:51]

Please add a TODO for me that this implementation does not actually work with
type arguments. It is OK now, but if we are changing it to actually be inlined,
we'll have to fix it.

[ngeoffray, 2013/09/17 12:02:24]

I've implemented it instead.

-      // TODO(ahe): This is only for reflection, and it is not correct yet.
-      value = graph.addConstantNull(compiler);
+      FunctionElement element = elements[node.expression];
+      FunctionElement function = currentElement;
+      List<HInstruction> inputs = <HInstruction>[];
+      FunctionSignature calleeSignature = element.functionSignature;
+      FunctionSignature callerSignature = function.functionSignature;
+      callerSignature.forEachRequiredParameter((Element element) {
+        inputs.add(localsHandler.readLocal(element));
+      });
+      List<Element> calleeOptionals =
+          calleeSignature.orderedOptionalParameters;
+      List<Element> callerOptionals =
+          callerSignature.orderedOptionalParameters;
+      int i = 0;
+      for (; i < callerOptionals.length; i++) {
+        inputs.add(localsHandler.readLocal(callerOptionals[i]));
+      }
+      for (; i < calleeOptionals.length; i++) {
+        inputs.add(handleConstantForOptionalParameter(calleeOptionals[i]));
+      }
+
+      if (backend.classNeedsRti(element.getEnclosingClass())) {
+        ClassElement cls = function.getEnclosingClass();
+        cls.typeVariables.forEach((TypeVariableType typeVariable) {
+          inputs.add(localsHandler.readLocal(typeVariable.element));
+        });
+      }
+      pushInvokeStatic(node, element, inputs);
+      value = pop();
     } else if (node.expression == null) {
       value = graph.addConstantNull(compiler);
     } else {
       visit(node.expression);
       value = pop();
       value = potentiallyCheckType(value, returnType);
     }
 
     handleInTryStatement();
 
@@ skipping 1311 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }