Issue 23450002: Bugfix in the inferrer for named optional parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23450002: Bugfix in the inferrer for named optional parameter. (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Bugfix in the inferrer for named optional parameter. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26684

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download
	A	tests/language/inferrer_named_parameter_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! —except that the nested conditional expressions doesn't look good at all ;-) https://codereview.chromium.org/23450002/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File ...

7 years, 3 months ago (2013-08-26 19:59:40 UTC) #2

ngeoffray

Thanks Peter. https://codereview.chromium.org/23450002/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/23450002/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1214 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1214: : null; On 2013/08/26 19:59:41, ahe wrote: ...

7 years, 3 months ago (2013-08-26 20:47:42 UTC) #3

ngeoffray

7 years, 3 months ago (2013-08-27 06:24:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26684 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23450002: Bugfix in the inferrer for named optional parameter. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages