Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 23450002: Bugfix in the inferrer for named optional parameter. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/inferrer_named_parameter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (revision 26632)
+++ sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (working copy)
@@ -1207,11 +1207,14 @@
if (!visitingOptionalParameter) {
type = arguments.positional[parameterIndex];
} else {
- type = signature.optionalParametersAreNamed
- ? arguments.named[parameter.name]
- : parameterIndex < arguments.positional.length
- ? arguments.positional[parameterIndex]
- : info.defaultType;
+ if (signature.optionalParametersAreNamed) {
+ type = arguments.named[parameter.name];
+ if (type == null) type = info.defaultType;
+ } else if (parameterIndex < arguments.positional.length) {
+ type = arguments.positional[parameterIndex];
+ } else {
+ type = info.defaultType;
+ }
}
TypeMask oldType = info.assignments[node];
info.addAssignment(node, type);
« no previous file with comments | « no previous file | tests/language/inferrer_named_parameter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698