Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 23449018: Fix inferrer bug in the presence of synthesized constructors: we should always notify a call to the… (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
ahe, karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix inferrer bug in the presence of synthesized constructors: we should always notify a call to the super constructor to know what are the types of the optional parameters. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27010

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -42 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 15 chunks +45 lines, -42 lines 0 comments Download
A tests/language/inferrer_synthesized_constructor_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-01 19:01:38 UTC) #1
ahe
LGTM Really appreciate the comments in the test!
7 years, 3 months ago (2013-09-01 19:58:08 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-02 11:00:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27010 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698