Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tests/language/inferrer_synthesized_constructor_test.dart

Issue 23449018: Fix inferrer bug in the presence of synthesized constructors: we should always notify a call to the… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/inferrer_synthesized_constructor_test.dart
===================================================================
--- tests/language/inferrer_synthesized_constructor_test.dart (revision 0)
+++ tests/language/inferrer_synthesized_constructor_test.dart (revision 0)
@@ -0,0 +1,26 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js's type inferrer that used to not
+// propagate default types in synthesized calls.
+
+import "package:expect/expect.dart";
+
+class A {
+ final x;
+ A([this.x = 'foo']);
+}
+
+class B extends A {
+ // The synthesized constructor was not saying that it would call
+ // [A]'s constructor with its default type.
+}
+
+main() {
+ // By calling [B]'s constructor with an int parameter, the inferrer
+ // used to only see this call and consider the [A.x] field to always
+ // be int.
+ Expect.equals(84, new A(42).x + 42);
+ Expect.throws(() => new B().x + 42, (e) => e is ArgumentError);
+}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698