Issue 23442011: Revert "Revert "Basic functionality is working with JS native support and polyfill, still some issu…

Issue 23442011: Revert "Revert "Basic functionality is working with JS native support and polyfill, still some issu… (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Tag extensions"" Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27313

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+688 lines, -253 lines)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View		9 chunks	+87 lines, -61 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		9 chunks	+130 lines, -13 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		4 chunks	+74 lines, -7 lines	0 comments	Download
M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/html/custom/created_callback_test.dart	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	tests/html/custom/document_register_basic_test.dart	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View	1	2 chunks	+214 lines, -153 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	1	3 chunks	+41 lines, -3 lines	2 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	3 chunks	+18 lines, -8 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View	1	1 chunk	+72 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/23442011/diff/18001/tools/dom/src/dart2js_CustomElementSupport.dart File tools/dom/src/dart2js_CustomElementSupport.dart (right): https://codereview.chromium.org/23442011/diff/18001/tools/dom/src/dart2js_CustomElementSupport.dart#newcode68 tools/dom/src/dart2js_CustomElementSupport.dart:68: getNativeInterceptor(new Element.tag('article')); should this create an instance of ...

7 years, 3 months ago (2013-09-09 21:46:57 UTC) #2

blois

https://codereview.chromium.org/23442011/diff/18001/tools/dom/src/dart2js_CustomElementSupport.dart File tools/dom/src/dart2js_CustomElementSupport.dart (right): https://codereview.chromium.org/23442011/diff/18001/tools/dom/src/dart2js_CustomElementSupport.dart#newcode68 tools/dom/src/dart2js_CustomElementSupport.dart:68: getNativeInterceptor(new Element.tag('article')); On 2013/09/09 21:46:57, John Messerly wrote: > ...

7 years, 3 months ago (2013-09-09 21:56:58 UTC) #3

blois

7 years, 3 months ago (2013-09-09 22:03:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27313 (presubmit successful).

Expand Messages | Collapse Messages