Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: tests/html/custom/document_register_basic_test.dart

Issue 23442011: Revert "Revert "Basic functionality is working with JS native support and polyfill, still some issu… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/html/custom/document_register_basic_test.dart
diff --git a/tests/html/custom/document_register_basic_test.dart b/tests/html/custom/document_register_basic_test.dart
index eb914476ecaf8dea73c976f194e8717df5266cc0..6934a473b9bb07937627ee397ec3f103d5cddfaa 100644
--- a/tests/html/custom/document_register_basic_test.dart
+++ b/tests/html/custom/document_register_basic_test.dart
@@ -37,11 +37,25 @@ class BadE implements HtmlElement {
factory BadE() => new Element.tag(tag);
}
+loadPolyfills() {
+ if (!document.supportsRegister) {
+ // Cache blocker is a workaround for:
+ // https://code.google.com/p/dart/issues/detail?id=11834
+ var cacheBlocker = new DateTime.now().millisecondsSinceEpoch;
+ return HttpRequest.getString('/root_dart/pkg/custom_element/lib/'
+ 'custom-elements.debug.js?cacheBlock=$cacheBlocker').then((code) {
+ document.head.children.add(new ScriptElement()..text = code);
+ });
+ }
+}
+
main() {
useHtmlConfiguration();
// Adapted from Blink's fast/dom/custom/document-register-basic test.
+ setUp(loadPolyfills);
+
test('Testing document.register() basic behaviors', () {
document.register(Foo.tag, Foo);
@@ -86,6 +100,7 @@ main() {
document.body.append(container);
container.setInnerHtml("<x-foo></x-foo>",
treeSanitizer: new NullTreeSanitizer());
+ Platform.upgradeCustomElements(container);
var parsedFoo = container.firstChild;
expect(parsedFoo is Foo, isTrue);
@@ -121,6 +136,7 @@ main() {
container.setInnerHtml("<X-BAR></X-BAR><X-Bar></X-Bar>",
treeSanitizer: new NullTreeSanitizer());
+ Platform.upgradeCustomElements(container);
expect(container.firstChild is Bar, isTrue);
expect(container.firstChild.tagName, "X-BAR");
expect(container.lastChild is Bar, isTrue);

Powered by Google App Engine
This is Rietveld 408576698