Issue 23201013: pkg/barback: removed unused imports, added a missing import

Issue 23201013: pkg/barback: removed unused imports, added a missing import (Closed)

Created:
7 years, 4 months ago by kevmoo-old

Modified:
7 years, 4 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/barback: removed unused imports, added a missing import R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=26330

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -33 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/asset_id.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/barback/lib/src/asset_node.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/asset_set.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/build_result.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/barback/lib/src/change_batch.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/errors.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/package_graph.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View	2 chunks	+1 line, -2 lines	1 comment	Download
M	pkg/barback/lib/src/transform.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/transformer.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/test/asset_id_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/barback/test/asset_set_test.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/barback/test/package_graph/errors_test.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/barback/test/package_graph/source_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/barback/test/package_graph/transform_test.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/barback/test/transformer/many_to_one.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Make sure you merge with latest before submitting, then LGTM. https://codereview.chromium.org/23201013/diff/1/pkg/barback/lib/src/phase.dart File pkg/barback/lib/src/phase.dart (right): https://codereview.chromium.org/23201013/diff/1/pkg/barback/lib/src/phase.dart#newcode325 ...

7 years, 4 months ago (2013-08-19 23:03:55 UTC) #2

kevmoo-old

7 years, 4 months ago (2013-08-19 23:30:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26330 (presubmit successful).

Expand Messages | Collapse Messages