Distinguish between malformed and malbounded types (fix issues 12552 and 12554).

Distinguish between malformed and malbounded types (fix issues 12552 and 12554).
Add test.
Update status files.

Explanation of change: A malbounded type argument should not be mapped to
dynamic, as is a malformed type argument.
This change also adds a bunch of TODOs related to the encounter of malbounded
types in unexpected places.
A follow-up change will address these TODOs, add more tests, and may simplify
code that is still handling malformed types where they cannot occur anymore
after the spec simplified their handling.

R=hausner@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26665

[hausner, 2013-08-23 16:55:23]

LGTM.

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10878: if (type_arguments.IsNull()) {
You could avoid this handle allocation by comparing arguments() directly to
AbstractTypeArguments::null(). Only if it is non-null do you need to allocate
the handle.

[srdjan, 2013-08-23 23:47:02]

lgtm

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.h#newcode3764
runtime/vm/object.h:3764: virtual bool IsMalbounded(Error* bound_error) const;
I think it would be better to have tow methods:
- IsMalboundedWithError(Error* bound_error)
- IsMalbounded();

At call site we see often IsMalbounded(NULL), which is longer and is mystifying
(why do we pass NULL?).

[regis, 2013-08-26 17:44:56]

Thanks!

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10878: if (type_arguments.IsNull()) {
On 2013/08/23 16:55:23, hausner wrote:
> You could avoid this handle allocation by comparing arguments() directly to
> AbstractTypeArguments::null(). Only if it is non-null do you need to allocate
> the handle.

Done.

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23190035/diff/1/runtime/vm/object.h#newcode3764
runtime/vm/object.h:3764: virtual bool IsMalbounded(Error* bound_error) const;
On 2013/08/23 23:47:02, srdjan wrote:
> I think it would be better to have tow methods:
> - IsMalboundedWithError(Error* bound_error)
> - IsMalbounded();
> 
> At call site we see often IsMalbounded(NULL), which is longer and is
mystifying
> (why do we pass NULL?).

Done.

[regis, 2013-08-26 17:56:11]

Committed patchset #3 manually as r26665 (presubmit successful).