Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: runtime/vm/object.h

Issue 23190035: Distinguish between malformed and malbounded types (fix issues 12552 and 12554). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 26663)
+++ runtime/vm/object.h (working copy)
@@ -3766,6 +3766,8 @@
virtual bool IsFinalized() const;
virtual bool IsBeingFinalized() const;
virtual bool IsMalformed() const;
+ virtual bool IsMalbounded() const { return IsMalboundedWithError(NULL); }
+ virtual bool IsMalboundedWithError(Error* bound_error) const;
virtual RawError* malformed_error() const;
virtual void set_malformed_error(const Error& value) const;
virtual bool IsResolved() const;
@@ -3903,6 +3905,8 @@
}
void set_is_being_finalized() const;
virtual bool IsMalformed() const;
+ virtual bool IsMalbounded() const { return IsMalboundedWithError(NULL); }
+ virtual bool IsMalboundedWithError(Error* bound_error) const;
virtual RawError* malformed_error() const;
virtual void set_malformed_error(const Error& value) const;
virtual bool IsResolved() const; // Class and all arguments classes resolved.
@@ -4010,6 +4014,8 @@
void set_is_finalized() const;
virtual bool IsBeingFinalized() const { return false; }
virtual bool IsMalformed() const { return false; }
+ virtual bool IsMalbounded() const { return false; }
+ virtual bool IsMalboundedWithError(Error* bound_error) const { return false; }
virtual bool IsResolved() const { return true; }
virtual bool HasResolvedTypeClass() const { return false; }
RawClass* parameterized_class() const {
@@ -4072,6 +4078,8 @@
return AbstractType::Handle(type()).IsBeingFinalized();
}
virtual bool IsMalformed() const;
+ virtual bool IsMalbounded() const { return IsMalboundedWithError(NULL); }
+ virtual bool IsMalboundedWithError(Error* bound_error) const;
virtual RawError* malformed_error() const;
virtual bool IsResolved() const { return true; }
virtual bool HasResolvedTypeClass() const {
@@ -4139,7 +4147,9 @@
public:
// MixinAppType objects are replaced with their actual finalized type.
virtual bool IsFinalized() const { return false; }
+ // TODO(regis): Handle malformed and malbounded MixinAppType.
virtual bool IsMalformed() const { return false; }
+ virtual bool IsMalbounded() const { return false; }
virtual bool IsResolved() const { return false; }
virtual bool HasResolvedTypeClass() const { return false; }
virtual RawString* Name() const;
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698