Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 23060025: Simplify the generated code for a message. (Closed)

Created:
7 years, 4 months ago by Alan Knight
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Simplify the generated code for a message. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M pkg/intl/lib/message_lookup_by_library.dart View 1 chunk +3 lines, -17 lines 0 comments Download
M pkg/intl/lib/src/intl_message.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
It struck me that there's no reason we can't have the generated code be just ...
7 years, 4 months ago (2013-08-22 18:14:20 UTC) #1
Emily Fortuna
nice. yay! lgtm
7 years, 4 months ago (2013-08-22 18:30:22 UTC) #2
Alan Knight
7 years, 4 months ago (2013-08-22 19:23:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698