Remove the Path class from dart:io

Remove the Path class from dart:io

The Path class in dart:io has been deprecated for some time
now. It was scheduled to be removed on August 11th, so here it
goes.

dart:io still uses the Path class internally, but now it is
private. I will trim it down to what is actually used in a
follow-up change.

R=ahe@google.com, devoncarew@google.com, whesse@google.com
BUG=http://dartbug.com/11666

Committed: https://code.google.com/p/dart/source/detail?r=26181

[Søren Gjesse, 2013-08-14 14:05:00]

Devon: How do I test the chenges in
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/chrome/build.dart?

[Bill Hesse, 2013-08-14 14:58:53]

Just reviewed the files in sdk/lib/io, and standalone.status.
They LGTM.  Let's go through and completely remove the private copy soon,
though.

https://codereview.chromium.org/23054008/diff/3001/samples/tests/samples/stan...
File samples/tests/samples/standalone/sample_extension_test.dart (right):

https://codereview.chromium.org/23054008/diff/3001/samples/tests/samples/stan...
samples/tests/samples/standalone/sample_extension_test.dart:31: return
join(buildDirectory, 'lib.target/libsample_extension.so');
In test_extension, I do join(buildDirectory, 'lib.target',
'libsample_extension.so').
Similarly below with '../../../sample_extension'.

https://codereview.chromium.org/23054008/diff/3001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/23054008/diff/3001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:1593: var absolute = new
_Path.raw(previous.uri.path).directoryPath;
I'm sure this one can be gotten rid of in a future CL.  In fact, all o f them in
dart:io can be, I think.

[devoncarew, 2013-08-14 15:30:19]

On 2013/08/14 14:05:00, Søren Gjesse wrote:
> Devon: How do I test the chenges in
>
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/chrome/build.dart?

You can build the editor via tools/build.py -mrelease editor

That'll put a copy in the output dir, next to dart-sdk. If you invoke the editor
from the command-line with --test, it'll run through its test suite. That
includes tests for the editor wizard samples. Those tests just do static
analysis, so it'll tell you that there aren't any analysis warnings.

If you start that editor and create a new project, you can select a new chrome
app project. That creates a project based around that generator/chrome template
code. It'll run build.dart automatically; no errors means it's happy. You can't
run the chrome app itself; that copy of the editor will not have Dartium
installed.

[ahe, 2013-08-14 16:14:09]

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
utils/compiler/create_snapshot.dart:6: import "package:path/path.dart";
I'm going to be very unreasonable and ask you to not import this particular
package.

[Søren Gjesse, 2013-08-15 09:07:12]

PTAL

Removed the dependencies on the path package from create_snapshot.dart and
build.dart and used file URIs instead.

Ran all the editor tests and also tested build.dart manually.

https://codereview.chromium.org/23054008/diff/3001/samples/tests/samples/stan...
File samples/tests/samples/standalone/sample_extension_test.dart (right):

https://codereview.chromium.org/23054008/diff/3001/samples/tests/samples/stan...
samples/tests/samples/standalone/sample_extension_test.dart:31: return
join(buildDirectory, 'lib.target/libsample_extension.so');
On 2013/08/14 14:58:54, Bill Hesse wrote:
> In test_extension, I do join(buildDirectory, 'lib.target',
> 'libsample_extension.so').
> Similarly below with '../../../sample_extension'.

Done.

https://codereview.chromium.org/23054008/diff/3001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/23054008/diff/3001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:1593: var absolute = new
_Path.raw(previous.uri.path).directoryPath;
On 2013/08/14 14:58:54, Bill Hesse wrote:
> I'm sure this one can be gotten rid of in a future CL.  In fact, all o f them
in
> dart:io can be, I think.

They sure can.

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
utils/compiler/create_snapshot.dart:6: import "package:path/path.dart";
On 2013/08/14 16:14:09, ahe wrote:
> I'm going to be very unreasonable and ask you to not import this particular
> package.

Removed, and changed this file to use the Uri class instead.

Btw. this code is only used for dartdoc snapshot, and not for the dart2js
snapshot.

[ahe, 2013-08-15 09:29:00]

utils/compiler/create_snapshot.dart, LGTM!

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/23054008/diff/3001/utils/compiler/create_snap...
utils/compiler/create_snapshot.dart:6: import "package:path/path.dart";
On 2013/08/15 09:07:12, Søren Gjesse wrote:
> On 2013/08/14 16:14:09, ahe wrote:
> > I'm going to be very unreasonable and ask you to not import this particular
> > package.
> 
> Removed, and changed this file to use the Uri class instead.
> 
> Btw. this code is only used for dartdoc snapshot, and not for the dart2js
> snapshot.

Hopefully, that is temporary.

https://codereview.chromium.org/23054008/diff/12001/utils/compiler/create_sna...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/23054008/diff/12001/utils/compiler/create_sna...
utils/compiler/create_snapshot.dart:25: import '${dart2js.toFilePath()}' as
dart2jsMain;
That isn't right. Dart imports use URI syntax.

[devoncarew, 2013-08-15 09:34:21]

lgtm

the build.dart change looks good, thanks

[Søren Gjesse, 2013-08-15 10:11:16]

Committed patchset #3 manually as r26181 (presubmit successful).