pkg/analyzer_experimental/lib/options.dart - Issue 23054008: Remove the Path class from dart:io

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_experimental/lib/options.dart

Issue 23054008: Remove the Path class from dart:io (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed first round of review comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer_experimental/lib/options.dart

diff --git a/pkg/analyzer_experimental/lib/options.dart b/pkg/analyzer_experimental/lib/options.dart

index dd841f0a3c43f3f376871a119302bc4a87158cf6..25a496c68386e4131b8d447e9cf0d72a87f4a2af 100644

--- a/pkg/analyzer_experimental/lib/options.dart

+++ b/pkg/analyzer_experimental/lib/options.dart

@@ -5,6 +5,7 @@

library options;

import 'package:args/args.dart';

+import 'package:path/path.dart';

import 'dart:io';

@@ -153,8 +154,7 @@ class CommandLineOptions {

static String _getVersion() {

try {

- Path path = new Path(Platform.script);

- Path versionPath = path.directoryPath.append('..').append('version');

+ Path versionPath = join(dirname(Platform.script), '..', 'version');;

File versionFile = new File.fromPath(versionPath);

return versionFile.readAsStringSync().trim();

} catch (_) {