Mark private methods of core libraries as invisible in the VM.

Mark private methods of core libraries as invisible in the VM.

This prevents accessing them via reflection which should not
be allowed since they are often handled specially by the compiler.
Those functions also will not be shown in stacktraces.

TEST=tests/language/reflect_core_vm_test.dart
R=rmacnak@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26625

[srdjan, 2013-08-23 13:58:17]

lgtm

https://codereview.chromium.org/23019013/diff/1/tests/language/reflect_core_v...
File tests/language/reflect_core_vm_test.dart (right):

https://codereview.chromium.org/23019013/diff/1/tests/language/reflect_core_v...
tests/language/reflect_core_vm_test.dart:15: Expect.isTrue(false);  //
Unreachable.
Expect.throws(() =>im.invoke(const Symbol("_setAt"), [0, 65]), (e) => e is
NoSuchMethodError);

[rmacnak, 2013-08-23 20:39:40]

I think the test belongs in tests/lib/mirrors.

Also, you'll need to mark it as failing on dart2js because their Symbol
constructor won't accept private identifiers (we haven't yet decided on an API
to construct them w/r/t some library).

LGTM

[Florian Schneider, 2013-08-26 08:53:44]

On 2013/08/23 20:39:40, Ryan Macnak wrote:
> I think the test belongs in tests/lib/mirrors.
> 
> Also, you'll need to mark it as failing on dart2js because their Symbol
> constructor won't accept private identifiers (we haven't yet decided on an API
> to construct them w/r/t some library).
>

It is a vm_test, so it will be skipped for dart2js.
 
> LGTM

[Florian Schneider, 2013-08-26 09:20:33]

Committed patchset #1 manually as r26625 (presubmit successful).

[Florian Schneider, 2013-08-26 09:37:32]

On 2013/08/26 08:53:44, Florian Schneider wrote:
> On 2013/08/23 20:39:40, Ryan Macnak wrote:
> > I think the test belongs in tests/lib/mirrors.
> > 
> > Also, you'll need to mark it as failing on dart2js because their Symbol
> > constructor won't accept private identifiers (we haven't yet decided on an
API
> > to construct them w/r/t some library).
> >
> 
> It is a vm_test, so it will be skipped for dart2js.
>  
> > LGTM

Ok, my fault - there is now a directory tests/language/vm instead of just naming
the tests *vm_test.dart. I moved the test to there.