Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: runtime/vm/exceptions.cc

Issue 23019013: Mark private methods of core libraries as invisible in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | tests/language/reflect_core_vm_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc (revision 26583)
+++ runtime/vm/exceptions.cc (working copy)
@@ -412,21 +412,13 @@
// TODO(5411263): At some point we can optimize by figuring out if a
// stack trace is needed based on whether the catch code specifies a
// stack trace object or there is a rethrow in the catch clause.
- if (pc_offset_array.Length() != 0) {
- if (existing_stacktrace.IsNull()) {
+ if (existing_stacktrace.IsNull()) {
stacktrace = Stacktrace::New(func_array, code_array, pc_offset_array);
- } else {
- stacktrace ^= existing_stacktrace.raw();
- stacktrace.Append(func_array, code_array, pc_offset_array);
- // Since we are re throwing and appending to the existing stack trace
- // we clear out the catch trace collected in the existing stack trace
- // as that trace will not be valid anymore.
- stacktrace.SetCatchStacktrace(Object::empty_array(),
- Object::empty_array(),
- Object::empty_array());
- }
} else {
stacktrace ^= existing_stacktrace.raw();
+ if (pc_offset_array.Length() != 0) {
+ stacktrace.Append(func_array, code_array, pc_offset_array);
+ }
// Since we are re throwing and appending to the existing stack trace
// we clear out the catch trace collected in the existing stack trace
// as that trace will not be valid anymore.
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | tests/language/reflect_core_vm_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698