Issue 23004009: Remove keyIdentifier from KeyboardEvent factory constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23004009: Remove keyIdentifier from KeyboardEvent factory constructor. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna

Modified:
7 years, 3 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove keyIdentifier from KeyboardEvent factory constructor. The new abilitity to specify a keycode/charcode/keyIdentifier will be allowed in our custom KeyEvent implementation coming in a subsequent CL. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26656

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -11 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 3 months ago (2013-08-26 16:44:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26656 (presubmit successful).

Expand Messages | Collapse Messages