Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 23004009: Remove keyIdentifier from KeyboardEvent factory constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 38e456c505b4dfeba5639d07c378c20bc9700e58..5ee4985d13f548775464ec5a716a92bbee77997d 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -14467,16 +14467,26 @@ class InputMethodContext extends Interceptor native "InputMethodContext" {
@DomName('KeyboardEvent')
class KeyboardEvent extends UIEvent native "KeyboardEvent" {
+ /**
+ * Programmatically create a KeyboardEvent.
+ *
+ * Due to browser differences, keyCode, charCode, or keyIdentifier values
+ * cannot be specified in this base level constructor. This constructor
+ * enables the user to programmatically create and dispatch a [KeyboardEvent],
+ * but it will not contain any particular key content. For programmatically
+ * creating keyboard events with specific key value contents, see the custom
+ * Event [KeyEvent].
+ */
factory KeyboardEvent(String type,
{Window view, bool canBubble: true, bool cancelable: true,
- String keyIdentifier: "", int keyLocation: 1, bool ctrlKey: false,
+ int keyLocation: 1, bool ctrlKey: false,
bool altKey: false, bool shiftKey: false, bool metaKey: false,
bool altGraphKey: false}) {
if (view == null) {
view = window;
}
final e = document.$dom_createEvent("KeyboardEvent");
- e.$dom_initKeyboardEvent(type, canBubble, cancelable, view, keyIdentifier,
+ e.$dom_initKeyboardEvent(type, canBubble, cancelable, view, "",
keyLocation, ctrlKey, altKey, shiftKey, metaKey, altGraphKey);
return e;
}
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698