Issue 23000011: Fix debugger stack traces

Issue 23000011: Fix debugger stack traces (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, justinfagnani, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix debugger stack traces This change fixes the lookup of exception handlers that are contained in activation frames that are not user-visible (e.g. frames in dart library code). Fixes issue 12318 (https://code.google.com/p/dart/issues/detail?id=12318) R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26445

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
M	runtime/vm/debugger.h	View	1	4 chunks	+20 lines, -7 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	7 chunks	+15 lines, -10 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/service.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.cc#newcode299 runtime/vm/debugger.cc:299: return Debugger::IsDebuggable(function()); If you move this code into ...

7 years, 4 months ago (2013-08-21 16:27:03 UTC) #2

hausner

Committed patchset #2 manually as r26445 (presubmit successful).

7 years, 4 months ago (2013-08-21 17:22:35 UTC) #3

hausner

7 years, 4 months ago (2013-08-21 20:26:12 UTC) #4

Message was sent while issue was closed.

Thank you

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.cc#newcod...
runtime/vm/debugger.cc:299: return Debugger::IsDebuggable(function());
On 2013/08/21 16:27:03, srdjan wrote:
> If you move this code into .h file, then no description is needed. Don't know
if
> that is feasible.

Could be moved but I prefer it here and hide the implementation.

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.h#newcode147
runtime/vm/debugger.h:147: bool IsDebuggable() const;
On 2013/08/21 16:27:03, srdjan wrote:
> Please document what that means (e.g. which frames are or are note
debuggable).

Done.

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.h#newcode212
runtime/vm/debugger.h:212: ASSERT(i < user_trace_.length());
On 2013/08/21 16:27:03, srdjan wrote:
> Redundant assert, it should be part of arrays []

Agree. Happy to remove it.

https://codereview.chromium.org/23000011/diff/1/runtime/vm/debugger.h#newcode222
runtime/vm/debugger.h:222: ASSERT(i < trace_.length());
On 2013/08/21 16:27:03, srdjan wrote:
> ditto.

ditto

Expand Messages | Collapse Messages