Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: runtime/vm/debugger_api_impl.cc

Issue 23000011: Fix debugger stack traces (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_debugger_api.h" 5 #include "include/dart_debugger_api.h"
6 6
7 #include "vm/class_finalizer.h" 7 #include "vm/class_finalizer.h"
8 #include "vm/compiler.h" 8 #include "vm/compiler.h"
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/dart_api_state.h" 10 #include "vm/dart_api_state.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 Dart_ActivationFrame* frame) { 90 Dart_ActivationFrame* frame) {
91 Isolate* isolate = Isolate::Current(); 91 Isolate* isolate = Isolate::Current();
92 DARTSCOPE(isolate); 92 DARTSCOPE(isolate);
93 CHECK_NOT_NULL(frame); 93 CHECK_NOT_NULL(frame);
94 CHECK_AND_CAST(DebuggerStackTrace, stack_trace, trace); 94 CHECK_AND_CAST(DebuggerStackTrace, stack_trace, trace);
95 if ((frame_index < 0) || (frame_index >= stack_trace->Length())) { 95 if ((frame_index < 0) || (frame_index >= stack_trace->Length())) {
96 return Api::NewError("argument 'frame_index' is out of range for %s", 96 return Api::NewError("argument 'frame_index' is out of range for %s",
97 CURRENT_FUNC); 97 CURRENT_FUNC);
98 } 98 }
99 *frame = reinterpret_cast<Dart_ActivationFrame>( 99 *frame = reinterpret_cast<Dart_ActivationFrame>(
100 stack_trace->ActivationFrameAt(frame_index)); 100 stack_trace->FrameAt(frame_index));
101 return Api::Success(); 101 return Api::Success();
102 } 102 }
103 103
104 static Dart_PausedEventHandler* paused_event_handler = NULL; 104 static Dart_PausedEventHandler* paused_event_handler = NULL;
105 static Dart_BreakpointResolvedHandler* bp_resolved_handler = NULL; 105 static Dart_BreakpointResolvedHandler* bp_resolved_handler = NULL;
106 static Dart_ExceptionThrownHandler* exc_thrown_handler = NULL; 106 static Dart_ExceptionThrownHandler* exc_thrown_handler = NULL;
107 static Dart_IsolateEventHandler* isolate_event_handler = NULL; 107 static Dart_IsolateEventHandler* isolate_event_handler = NULL;
108 108
109 static Dart_BreakpointHandler* legacy_bp_handler = NULL; 109 static Dart_BreakpointHandler* legacy_bp_handler = NULL;
110 110
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 850
851 851
852 DART_EXPORT char* Dart_GetVmStatus(const char* request) { 852 DART_EXPORT char* Dart_GetVmStatus(const char* request) {
853 if (strncmp(request, "/isolate/", 9) == 0) { 853 if (strncmp(request, "/isolate/", 9) == 0) {
854 return Isolate::GetStatus(request); 854 return Isolate::GetStatus(request);
855 } 855 }
856 return NULL; 856 return NULL;
857 } 857 }
858 858
859 } // namespace dart 859 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698