Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 22999020: pkg/unittest: give Configuration a default (blank) implementation (Closed)

Created:
7 years, 4 months ago by kevmoo-old
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: give Configuration a default (blank) implementation Use this to replace subclasses of SimpleConfiguration that mostly override members to replace behavior with no-op BUG= https://code.google.com/p/dart/issues/detail?id=12495 R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=26316

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M pkg/scheduled_test/test/metatest.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/unittest/lib/src/configuration.dart View 5 chunks +16 lines, -9 lines 0 comments Download
M pkg/unittest/lib/src/simple_configuration.dart View 1 2 4 chunks +3 lines, -5 lines 0 comments Download
M pkg/unittest/test/unittest_test_utils.dart View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
With this change: 1) Folks who are currently subclassing Configuration are still broken (by design). ...
7 years, 4 months ago (2013-08-16 23:36:28 UTC) #1
gram
lgtm
7 years, 4 months ago (2013-08-19 16:15:00 UTC) #2
kevmoo-old
7 years, 4 months ago (2013-08-19 17:27:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r26316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698