Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: pkg/unittest/lib/src/simple_configuration.dart

Issue 22999020: pkg/unittest: give Configuration a default (blank) implementation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/lib/src/configuration.dart ('k') | pkg/unittest/test/unittest_test_utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/simple_configuration.dart
diff --git a/pkg/unittest/lib/src/simple_configuration.dart b/pkg/unittest/lib/src/simple_configuration.dart
index b9d3a02bf87ee8dd5e6fbac0c09963bc9239d59c..d4a0f6e8c17d2a1998ccde087fa7fe72f5505ec4 100644
--- a/pkg/unittest/lib/src/simple_configuration.dart
+++ b/pkg/unittest/lib/src/simple_configuration.dart
@@ -22,7 +22,7 @@ class _ExpectFailureHandler extends DefaultFailureHandler {
* advantage of the platform can create a subclass and override methods from
* this class.
*/
-class SimpleConfiguration implements Configuration {
+class SimpleConfiguration extends Configuration {
// The VM won't shut down if a receive port is open. Use this to make sure
// we correctly wait for asynchronous tests.
ReceivePort _receivePort;
@@ -32,7 +32,7 @@ class SimpleConfiguration implements Configuration {
* Particularly useful in cases where we have parent/child configurations
* such as layout tests.
*/
- final String name = 'Configuration';
+ String get name => 'Configuration';
bool get autoStart => true;
@@ -56,7 +56,7 @@ class SimpleConfiguration implements Configuration {
* The constructor sets up a failure handler for [expect] that redirects
* [expect] failures to [onExpectFailure].
*/
- SimpleConfiguration() {
+ SimpleConfiguration() : super.blank() {
configureExpectFailureHandler(new _ExpectFailureHandler(this));
}
@@ -65,8 +65,6 @@ class SimpleConfiguration implements Configuration {
_postMessage('unittest-suite-wait-for-done');
}
- void onStart() {}
-
/**
* Called when each test starts. Useful to show intermediate progress on
* a test suite. Derived classes should call this first before their own
« no previous file with comments | « pkg/unittest/lib/src/configuration.dart ('k') | pkg/unittest/test/unittest_test_utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698