Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 22950003: Remove test for native resolver (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove test for native resolver This check asserts that a type with a native field must be in a library with a native resolver. It won't be true with custom elements - which inherit from dart:html and inherit a native field - but are otherwise in user libraries. I'm just removing the check altogether here. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26144

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment and mark tests pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M runtime/vm/parser.cc View 1 1 chunk +1 line, -15 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
7 years, 4 months ago (2013-08-13 00:17:05 UTC) #1
siva
https://codereview.chromium.org/22950003/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/22950003/diff/1/runtime/vm/parser.cc#newcode2608 runtime/vm/parser.cc:2608: innermost_function_ = func.raw(); I think we need some framework ...
7 years, 4 months ago (2013-08-13 00:43:05 UTC) #2
siva
I have created an issue https://code.google.com/p/dart/issues/detail?id=12455 to track the need for a better validation mechanism. ...
7 years, 4 months ago (2013-08-14 19:51:31 UTC) #3
vsm
7 years, 4 months ago (2013-08-14 20:18:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698