Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: runtime/vm/parser.cc

Issue 22950003: Remove test for native resolver (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add comment and mark tests pass Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index b4be5516c043bc17e201e9f4a3d323068e1ed0ef..a63642dde91cc00bf71ce6a3d219739aa01d58c9 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -2611,21 +2611,7 @@ SequenceNode* Parser::ParseFunc(const Function& func,
Function::Handle(innermost_function().raw());
innermost_function_ = func.raw();
- // Check to ensure we don't have classes with native fields in libraries
- // which do not have a native resolver. This check is delayed until the class
- // is actually used. Invocation of a function in the class is the first point
- // of use. Access of const static fields in the class do not trigger an error.
- if (current_class().num_native_fields() != 0) {
- const Library& lib = Library::Handle(current_class().library());
- if (lib.native_entry_resolver() == NULL) {
- const String& cls_name = String::Handle(current_class().Name());
- const String& lib_name = String::Handle(lib.url());
- ErrorMsg(current_class().token_pos(),
- "class '%s' is trying to extend a native fields class, "
- "but library '%s' has no native resolvers",
- cls_name.ToCString(), lib_name.ToCString());
- }
- }
+ // TODO(12455) : Need better validation mechanism.
if (func.IsConstructor()) {
SequenceNode* statements = ParseConstructor(func, default_parameter_values);
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698