Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 229453002: Support returning a Future from a setUp or test body in scheduled_test. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support returning a Future from a setUp or test body in scheduled_test. R=rnystrom@google.com BUG=18088 Committed: https://code.google.com/p/dart/source/detail?r=34849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -9 lines) Patch
M pkg/scheduled_test/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 3 chunks +22 lines, -9 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test/set_up_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test/wrap_future_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 8 months ago (2014-04-08 22:16:20 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-08 22:23:24 UTC) #2
nweiz
Committed patchset #1 manually as r34849 (presubmit successful).
6 years, 8 months ago (2014-04-08 22:45:50 UTC) #3
kasperl
6 years, 8 months ago (2014-04-09 05:25:43 UTC) #4
Message was sent while issue was closed.
Looks like this is causing redness on the analyzer build bot.

Powered by Google App Engine
This is Rietveld 408576698