Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: pkg/scheduled_test/test/scheduled_test/set_up_test.dart

Issue 229453002: Support returning a Future from a setUp or test body in scheduled_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/scheduled_test/set_up_test.dart
diff --git a/pkg/scheduled_test/test/scheduled_test/set_up_test.dart b/pkg/scheduled_test/test/scheduled_test/set_up_test.dart
index 1fbf80fa6c9e9c012d0043f319d35c2c9837c10f..2ebf35c88c4d3a4b8d88d17ae91e88dc10653629 100644
--- a/pkg/scheduled_test/test/scheduled_test/set_up_test.dart
+++ b/pkg/scheduled_test/test/scheduled_test/set_up_test.dart
@@ -176,4 +176,31 @@ void main(_, message) {
});
});
+ expectTestsPass("a future returned by setUp is implicitly wrapped", () {
+ var futureComplete = false;
+ setUp(() => pumpEventQueue().then((_) => futureComplete = true));
+
+ test('test', () {
+ currentSchedule.onComplete.schedule(() => expect(futureComplete, isTrue));
+ });
+ });
+
+ expectTestsPass("a future returned by setUp should not block test()", () {
+ var futureComplete = false;
+ setUp(() => pumpEventQueue().then((_) => futureComplete = true));
+
+ test('test', () {
+ expect(futureComplete, isFalse);
+ });
+ });
+
+ expectTestsPass("a future returned by setUp should not block the schedule",
+ () {
+ var futureComplete = false;
+ setUp(() => pumpEventQueue().then((_) => futureComplete = true));
+
+ test('test', () {
+ schedule(() => expect(futureComplete, isFalse));
+ });
+ });
}
« no previous file with comments | « pkg/scheduled_test/lib/scheduled_test.dart ('k') | pkg/scheduled_test/test/scheduled_test/wrap_future_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698