Formatter fixes and tweaks.

Formatter fixes and tweaks.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26462

[Brian Wilkerson, 2013-08-21 18:18:53]

LGTM

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:391: space();
Do you want to mark somehow (comment perhaps) that the space should only be
printed if there is a type? It might be hard to find later on.

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:956: space();
Similarly here, the spaces and equals are only wanted (and the equals can be
null) if the initializer is not null.

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/tes...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/tes...
pkg/analyzer_experimental/test/services/formatter_test.dart:159: '    for (var 
file in files) {\n'
I don't think you want to produce two spaces here.

[pquitslund, 2013-08-21 19:40:40]

Thanks Brian!

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:391: space();
On 2013/08/21 18:18:53, Brian Wilkerson wrote:
> Do you want to mark somehow (comment perhaps) that the space should only be
> printed if there is a type? It might be hard to find later on.

Good catch.  Fixed!

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:956: space();
On 2013/08/21 18:18:53, Brian Wilkerson wrote:
> Similarly here, the spaces and equals are only wanted (and the equals can be
> null) if the initializer is not null.

Exactly right.  Thanks!

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/tes...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/22928013/diff/1/pkg/analyzer_experimental/tes...
pkg/analyzer_experimental/test/services/formatter_test.dart:159: '    for (var 
file in files) {\n'
On 2013/08/21 18:18:53, Brian Wilkerson wrote:
> I don't think you want to produce two spaces here.

Aha!  That explains why the code you commented on worked.

Thanks for the catch.

[pquitslund, 2013-08-21 19:41:38]

Committed patchset #1 manually as r26462 (presubmit successful).