Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 22918029: Change the type of the pathSegments argument to the Uri constructor from List to Iterable (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the type of the pathSegments argument to the Uri constructor from List to Iterable R=lrn@google.com BUG=http://dartbug/11342 Committed: https://code.google.com/p/dart/source/detail?r=26649

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M sdk/lib/core/uri.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/uri_path_test.dart View 1 2 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-08-26 10:25:41 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/22918029/diff/1/tests/corelib/uri_path_test.dart File tests/corelib/uri_path_test.dart (right): https://codereview.chromium.org/22918029/diff/1/tests/corelib/uri_path_test.dart#newcode116 tests/corelib/uri_path_test.dart:116: pathSegments: new DoubleLinkedQueue.from(pathSegments)); Try using something that has ...
7 years, 3 months ago (2013-08-26 13:55:37 UTC) #2
Søren Gjesse
https://codereview.chromium.org/22918029/diff/1/tests/corelib/uri_path_test.dart File tests/corelib/uri_path_test.dart (right): https://codereview.chromium.org/22918029/diff/1/tests/corelib/uri_path_test.dart#newcode116 tests/corelib/uri_path_test.dart:116: pathSegments: new DoubleLinkedQueue.from(pathSegments)); On 2013/08/26 13:55:37, Lasse Reichstein Nielsen ...
7 years, 3 months ago (2013-08-26 14:24:54 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-08-26 14:25:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698