Change the type of the pathSegments argument to the Uri constructor from List to Iterable

tests/corelib/uri_path_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import "dart:collection";
+
 import "package:expect/expect.dart";
 
 void testInvalidArguments() {
 }
 
 void testPath() {
   void test(s, uri) {
     Expect.equals(s, uri.toString());
     Expect.equals(uri, Uri.parse(s));
   }
@@ skipping 69 matching lines @@
       encoded.write(i.toRadixString(16).toUpperCase());
     }
     unencoded.writeCharCode(i);
   }
   encoded = encoded.toString();
   unencoded = unencoded.toString();
   test(encoded, [unencoded]);
   test(encoded + "/" + encoded, [unencoded, unencoded]);
 
   Uri uri;
-  uri = new Uri(pathSegments: ["xxx", "yyy", "zzz"]);
+  List pathSegments = ["xxx", "yyy", "zzz"];
+
+  uri = new Uri(pathSegments: pathSegments);
+  Expect.equals(3, uri.pathSegments.length);
+  uri = new Uri(pathSegments: new DoubleLinkedQueue.from(pathSegments));
+  Expect.equals(3, uri.pathSegments.length);
+
+  uri = new Uri(scheme: "http",
+                host: "host",
+                pathSegments: pathSegments);
   Expect.equals(3, uri.pathSegments.length);
   uri = new Uri(scheme: "http",
                 host: "host",
-                pathSegments: ["xxx", "yyy", "zzz"]);
+                pathSegments: new DoubleLinkedQueue.from(pathSegments));
+  Expect.equals(3, uri.pathSegments.length);
+
+  uri = new Uri(scheme: "file",
+                pathSegments: pathSegments);
   Expect.equals(3, uri.pathSegments.length);
   uri = new Uri(scheme: "file",
-                pathSegments: ["xxx", "yyy", "zzz"]);
+                pathSegments: new DoubleLinkedQueue.from(pathSegments));

[Lasse Reichstein Nielsen, 2013/08/26 13:55:37]

Try using something that has inefficient length, e.g.,
  pathSegments.where((_) => true)

[Søren Gjesse, 2013/08/26 14:24:54]

Done.

   Expect.equals(3, uri.pathSegments.length);
 }
 
 void testPathCompare() {
   void test(Uri uri1, Uri uri2) {
     Expect.equals(uri1, uri2);
     Expect.equals(uri2, uri1);
   }
 
   test(new Uri(scheme: "http", host: "host", path: "xxx"),
@@ skipping 49 matching lines @@
   test(new Uri(pathSegments: ["a", "b"]).pathSegments);
 }
 
 main() {
   testInvalidArguments();
   testPath();
   testPathSegments();
   testPathCompare();
   testPathSegmentsUnmodifiableList();
 }