Issue 22897019: Detect circular dependencies in compile time constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22897019: Detect circular dependencies in compile time constants (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Detect circular dependencies in compile time constants Fix issue 1681 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26491

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -3 lines)			Patch
M	runtime/vm/object_store.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 2	3 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	5 chunks	+36 lines, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/22897019/diff/7001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/22897019/diff/7001/runtime/vm/parser.cc#newcode2388 runtime/vm/parser.cc:2388: } ASSERT(!unregister_pending_function_) so that you do not enter ...

7 years, 4 months ago (2013-08-21 23:39:09 UTC) #2

hausner

Committed patchset #3 manually as r26491 (presubmit successful).

7 years, 4 months ago (2013-08-21 23:56:05 UTC) #3

hausner

7 years, 4 months ago (2013-08-21 23:57:12 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/22897019/diff/7001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22897019/diff/7001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:2388: }
On 2013/08/21 23:39:09, srdjan wrote:
> ASSERT(!unregister_pending_function_) so that you do not enter the same
function
> twice.

Done.

Expand Messages | Collapse Messages

Issue 22897019: Detect circular dependencies in compile time constants (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages