Detect circular dependencies in compile time constants

runtime/vm/object_store.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object_store.h"
 
 #include "vm/exceptions.h"
 #include "vm/dart_entry.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 45 matching lines @@
     isolate_library_(Library::null()),
     json_library_(Library::null()),
     math_library_(Library::null()),
     mirrors_library_(Library::null()),
     native_wrappers_library_(Library::null()),
     root_library_(Library::null()),
     typed_data_library_(Library::null()),
     utf_library_(Library::null()),
     libraries_(GrowableObjectArray::null()),
     pending_classes_(GrowableObjectArray::null()),
+    pending_functions_(GrowableObjectArray::null()),
     sticky_error_(Error::null()),
     unhandled_exception_handler_(String::null()),
     empty_context_(Context::null()),
     stack_overflow_(Instance::null()),
     out_of_memory_(Instance::null()),
     preallocated_stack_trace_(Stacktrace::null()),
     keyword_symbols_(Array::null()),
     receive_port_create_function_(Function::null()),
     lookup_receive_port_function_(Function::null()),
     handle_message_function_(Function::null()) {
@@ skipping 22 matching lines @@
   ASSERT(isolate != NULL && isolate->object_store() == this);
   if (this->stack_overflow() != Instance::null()) {
     ASSERT(this->out_of_memory() != Instance::null());
     ASSERT(this->preallocated_stack_trace() != Stacktrace::null());
     return true;
   }
   ASSERT(this->stack_overflow() == Instance::null());
   ASSERT(this->out_of_memory() == Instance::null());
   ASSERT(this->preallocated_stack_trace() == Stacktrace::null());
 
+  ASSERT(this->pending_functions() == GrowableObjectArray::null());
+  this->pending_functions_ = GrowableObjectArray::New();
+
   Object& result = Object::Handle();
   const Library& library = Library::Handle(Library::CoreLibrary());
 
   result = DartLibraryCalls::InstanceCreate(library,
                                             Symbols::StackOverflowError(),
                                             Symbols::Dot(),
                                             Object::empty_array());
   if (result.IsError()) {
     return false;
   }
@@ skipping 26 matching lines @@
 void ObjectStore::InitKeywordTable() {
   // Set up the keywords symbol array so that we can access it while scanning.
   Array& keywords = Array::Handle(keyword_symbols());
   ASSERT(keywords.IsNull());
   keywords = Array::New(Token::numKeywords, Heap::kOld);
   ASSERT(!keywords.IsError() && !keywords.IsNull());
   set_keyword_symbols(keywords);
 }
 
 }  // namespace dart