Issue 22871009: Address long-standing review comments.

Issue 22871009: Address long-standing review comments. (Closed)

Created:
7 years, 4 months ago by ngeoffray

Modified:
7 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address long-standing review comments. Comments were from: https://codereview.chromium.org/12299008/ https://codereview.chromium.org/11273121/ R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26196

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -28 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	1 chunk	+42 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		3 chunks	+12 lines, -14 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	tests/language/closure_in_initializer2_test.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/language/closure_in_initializer_test.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, but there are at least three empty lines too many. https://codereview.chromium.org/22871009/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): ...

7 years, 4 months ago (2013-08-15 15:56:53 UTC) #2

ngeoffray

Thank god it's you that reviewed it! https://codereview.chromium.org/22871009/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/22871009/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode141 sdk/lib/_internal/compiler/implementation/compiler.dart:141: On 2013/08/15 ...

7 years, 4 months ago (2013-08-15 16:06:59 UTC) #3

ngeoffray

7 years, 4 months ago (2013-08-15 16:07:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26196 (presubmit successful).

Expand Messages | Collapse Messages