Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 22871009: Address long-standing review comments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (revision 26191)
+++ sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (working copy)
@@ -772,11 +772,11 @@
ensure(jsUnknownJavaScriptObjectClass);
}
- void registerWrapException(TreeElements elements) {
+ void registerThrowExpression(TreeElements elements) {
+ // We don't know ahead of time whether we will need the throw in a
+ // statement context or an expression context, so we register both
+ // here, even though we may not need the throwExpression helper.
enqueueInResolution(getWrapExceptionHelper(), elements);
- }
-
- void registerThrowExpression(TreeElements elements) {
enqueueInResolution(getThrowExpressionHelper(), elements);
}

Powered by Google App Engine
This is Rietveld 408576698