Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 22871003: Issue 11892. It is compile-time error when unqualified invocation with unresolved identifier. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Issue 11892. It is compile-time error when unqualified invocation with unresolved identifier. https://code.google.com/p/dart/issues/detail?id=11892 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -54 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java View 4 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java View 1 chunk +10 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java View 1 chunk +0 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 3 chunks +13 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 2 chunks +35 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java View 1 chunk +0 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 2 chunks +0 lines, -16 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 4 months ago (2013-08-12 16:40:27 UTC) #1
Brian Wilkerson
LGTM
7 years, 4 months ago (2013-08-12 16:57:03 UTC) #2
scheglov
7 years, 4 months ago (2013-08-12 18:06:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698