Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java

Issue 22871003: Issue 11892. It is compile-time error when unqualified invocation with unresolved identifier. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java
diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java
index f922e81a731c4c19da45d3f8b0ccf9c1db789c8a..5c7fb3b152c40ea85580e4c0dcaae78c7d9a4301 100644
--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java
+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java
@@ -367,6 +367,11 @@ public class QuickFixProcessorImpl implements QuickFixProcessor {
if (errorCode == CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT) {
addFix_createConstructorSuperExplicit();
}
+ if (errorCode == CompileTimeErrorCode.UNDEFINED_FUNCTION) {
+ addFix_importLibrary_withFunction();
+ addFix_undefinedFunction_useSimilar();
+ addFix_undefinedFunction_create();
+ }
if (errorCode == CompileTimeErrorCode.URI_DOES_NOT_EXIST) {
addFix_createPart();
}
@@ -407,11 +412,6 @@ public class QuickFixProcessorImpl implements QuickFixProcessor {
if (errorCode == StaticTypeWarningCode.INVOCATION_OF_NON_FUNCTION) {
addFix_removeParentheses_inGetterInvocation();
}
- if (errorCode == StaticTypeWarningCode.UNDEFINED_FUNCTION) {
- addFix_importLibrary_withFunction();
- addFix_undefinedFunction_useSimilar();
- addFix_undefinedFunction_create();
- }
if (errorCode == StaticTypeWarningCode.UNDEFINED_METHOD) {
addFix_undefinedMethod_useSimilar();
addFix_undefinedMethod_create();
@@ -441,6 +441,7 @@ public class QuickFixProcessorImpl implements QuickFixProcessor {
return errorCode == CompileTimeErrorCode.NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT
|| errorCode == CompileTimeErrorCode.NO_DEFAULT_SUPER_CONSTRUCTOR_IMPLICIT
|| errorCode == CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT
+ || errorCode == CompileTimeErrorCode.UNDEFINED_FUNCTION
|| errorCode == CompileTimeErrorCode.URI_DOES_NOT_EXIST
|| errorCode == ParserErrorCode.EXPECTED_TOKEN
|| errorCode == ParserErrorCode.GETTER_WITH_PARAMETERS
@@ -454,7 +455,6 @@ public class QuickFixProcessorImpl implements QuickFixProcessor {
|| errorCode == StaticWarningCode.UNDEFINED_CLASS_BOOLEAN
|| errorCode == StaticWarningCode.UNDEFINED_IDENTIFIER
|| errorCode == StaticTypeWarningCode.INVOCATION_OF_NON_FUNCTION
- || errorCode == StaticTypeWarningCode.UNDEFINED_FUNCTION
|| errorCode == StaticTypeWarningCode.UNDEFINED_METHOD;
}
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698