Issue 22854028: Fix off-by-one error in UTF-8 encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22854028: Fix off-by-one error in UTF-8 encoding. (Closed)

Created:
7 years, 4 months ago by floitsch

Modified:
7 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix off-by-one error in UTF-8 encoding. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=26355

Patch Set 2 : Add more tests. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	sdk/lib/convert/utf.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/lib/convert/unicode_tests.dart	View	1	2 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/22854028/diff/1/tests/lib/convert/unicode_tests.dart File tests/lib/convert/unicode_tests.dart (right): https://codereview.chromium.org/22854028/diff/1/tests/lib/convert/unicode_tests.dart#newcode49 tests/lib/convert/unicode_tests.dart:49: const BIGGEST_ASCII_STRING = "\x7F"; Consider adding - "\x80" ...

7 years, 4 months ago (2013-08-20 13:56:49 UTC) #2

floitsch

https://codereview.chromium.org/22854028/diff/1/tests/lib/convert/unicode_tests.dart File tests/lib/convert/unicode_tests.dart (right): https://codereview.chromium.org/22854028/diff/1/tests/lib/convert/unicode_tests.dart#newcode49 tests/lib/convert/unicode_tests.dart:49: const BIGGEST_ASCII_STRING = "\x7F"; On 2013/08/20 13:56:49, Lasse Reichstein ...

7 years, 4 months ago (2013-08-20 14:03:22 UTC) #3

floitsch

7 years, 4 months ago (2013-08-20 14:03:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26355 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22854028: Fix off-by-one error in UTF-8 encoding. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add more tests. #

Messages