sdk/lib/convert/utf.dart - Issue 22854028: Fix off-by-one error in UTF-8 encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/convert/utf.dart

Issue 22854028: Fix off-by-one error in UTF-8 encoding. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add more tests. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/convert/utf.dart

diff --git a/sdk/lib/convert/utf.dart b/sdk/lib/convert/utf.dart

index f45a192679297ba55aa5df3326bff30ef3109049..80f7a7837f15ece8586f67385f46b0d3b5f3fd03 100644

--- a/sdk/lib/convert/utf.dart

+++ b/sdk/lib/convert/utf.dart

@@ -177,7 +177,7 @@ class _Utf8Encoder {

for (stringIndex = start; stringIndex < end; stringIndex++) {

int codeUnit = str.codeUnitAt(stringIndex);

// ASCII has the same representation in UTF-8 and UTF-16.

- if (codeUnit < _ONE_BYTE_LIMIT) {

+ if (codeUnit <= _ONE_BYTE_LIMIT) {

if (_bufferIndex >= _buffer.length) break;

_buffer[_bufferIndex++] = codeUnit;

} else if (_isLeadSurrogate(codeUnit)) {

« no previous file with comments | « no previous file | tests/lib/convert/unicode_tests.dart » ('j') | no next file with comments »