Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2285133005: pkg/test: Fix a few analyzer warnings (Closed)

Created:
4 years, 3 months ago by kevmoo
Modified:
4 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/test.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M lib/src/runner/browser/post_message_channel.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/io.dart View 2 chunks +5 lines, -7 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
kevmoo
4 years, 3 months ago (2016-08-30 04:43:09 UTC) #2
nweiz
https://codereview.chromium.org/2285133005/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/2285133005/diff/1/test/io.dart#newcode136 test/io.dart:136: var allArgs = <Object>[] <String>[]
4 years, 3 months ago (2016-08-30 20:23:20 UTC) #3
kevmoo
https://codereview.chromium.org/2285133005/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/2285133005/diff/1/test/io.dart#newcode136 test/io.dart:136: var allArgs = <Object>[] On 2016/08/30 20:23:20, nweiz wrote: ...
4 years, 3 months ago (2016-08-30 22:11:49 UTC) #4
nweiz
lgtm
4 years, 3 months ago (2016-08-30 22:17:23 UTC) #5
kevmoo
4 years, 3 months ago (2016-08-30 22:17:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3230bd991805b46ac4e78ea91626d4e0f0c26b0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698