Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: test/io.dart

Issue 2285133005: pkg/test: Fix a few analyzer warnings (Closed) Base URL: https://github.com/dart-lang/test.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/post_message_channel.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/io.dart
diff --git a/test/io.dart b/test/io.dart
index 331a220b38545ad6cf5213663178e6ec9b876fb9..b9eec58fda77f15024435de83be344343bde130d 100644
--- a/test/io.dart
+++ b/test/io.dart
@@ -8,7 +8,6 @@ library test.test.io;
import 'dart:async';
import 'dart:io';
-import 'dart:isolate';
import 'package:package_resolver/package_resolver.dart';
import 'package:path/path.dart' as p;
@@ -134,12 +133,11 @@ ScheduledProcess runTest(List<String> args, {String reporter,
/// Runs Dart.
ScheduledProcess runDart(List<String> args, {Map<String, String> environment,
String description}) {
- var allArgs = Platform.executableArguments
- .where((arg) =>
- !arg.startsWith("--package-root=") && !arg.startsWith("--packages="))
- .toList()
- ..add(PackageResolver.current.processArgument)
- ..addAll(args);
+ var allArgs = <Object>[]
nweiz 2016/08/30 20:23:20 <String>[]
kevmoo 2016/08/30 22:11:49 Nope. This was the problem. This contains both `St
+ ..addAll(Platform.executableArguments.where((arg) =>
+ !arg.startsWith("--package-root=") && !arg.startsWith("--packages=")))
+ ..add(PackageResolver.current.processArgument)
+ ..addAll(args);
return new ScheduledProcess.start(
p.absolute(Platform.resolvedExecutable), allArgs,
« no previous file with comments | « lib/src/runner/browser/post_message_channel.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698