Issue 22846005: Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block.

Issue 22846005: Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block. (Closed)

Created:
7 years, 4 months ago by scheglov

Modified:
7 years, 4 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26060

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -4 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java	View	4 chunks	+28 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/EnclosedScope.java	View	4 chunks	+28 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/22846005/diff/1/tests/language/language_analyzer.status File tests/language/language_analyzer.status (right): https://codereview.chromium.org/22846005/diff/1/tests/language/language_analyzer.status#newcode278 tests/language/language_analyzer.status:278: # test issue 12397; it is statis warning, ...

7 years, 4 months ago (2013-08-12 22:18:19 UTC) #2

jwren

On 2013/08/12 22:18:19, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/22846005/diff/1/tests/language/language_analyzer.status > File tests/language/language_analyzer.status (right): ...

7 years, 4 months ago (2013-08-12 22:21:40 UTC) #3

scheglov

7 years, 4 months ago (2013-08-13 16:24:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26060 (presubmit successful).

Expand Messages | Collapse Messages