editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java - Issue 22846005: Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

Issue 22846005: Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/EnclosedScope.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java » ('j') | tests/language/language_analyzer.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

index c0e3f97bf8eaff3450f59368734f478188e0de40..3a6f7de8aa3d363f941846f9d5fe90beb22394a6 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

@@ -109,7 +109,8 @@ public abstract class Scope {

* @param element the element to be added to this scope

protected void defineWithoutChecking(Element element) {

- definedNames.put(getName(element), element);

+ String name = getName(element);

+ definedNames.put(name, element);

}

/**