Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 22833005: Allow infering of return types on runtime helpers. It's only arugments the inferrer does not see. (Closed)

Created:
7 years, 4 months ago by ngeoffray
Modified:
7 years, 4 months ago
Reviewers:
karlklose, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow infering of return types on runtime helpers. It's only arugments the inferrer does not see. Also fix a few dependencies of runtime errors requiring the string class to be instantiated. R=ahe@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=26189

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +0 lines, -3 lines 0 comments Download
A tests/compiler/dart2js/no_such_method_codegen_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
7 years, 4 months ago (2013-08-15 11:22:41 UTC) #1
ahe
Nice! I think this is going to work really well for mirrors as well :-) ...
7 years, 4 months ago (2013-08-15 11:27:43 UTC) #2
ngeoffray
Thanks Peter. https://codereview.chromium.org/22833005/diff/11001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/22833005/diff/11001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode906 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:906: compiler.enqueuer.resolution.registerInstantiatedClass( On 2013/08/15 11:27:43, ahe wrote: > ...
7 years, 4 months ago (2013-08-15 11:31:34 UTC) #3
karlklose
LGTM.
7 years, 4 months ago (2013-08-15 11:32:54 UTC) #4
ngeoffray
7 years, 4 months ago (2013-08-15 11:53:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r26189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698