Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 22833005: Allow infering of return types on runtime helpers. It's only arugments the inferrer does not see. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 class JavaScriptItemCompilationContext extends ItemCompilationContext { 7 class JavaScriptItemCompilationContext extends ItemCompilationContext {
8 final Set<HInstruction> boundsChecked; 8 final Set<HInstruction> boundsChecked;
9 9
10 JavaScriptItemCompilationContext() 10 JavaScriptItemCompilationContext()
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 enqueueInResolution(helper.getElement(compiler), elements); 896 enqueueInResolution(helper.getElement(compiler), elements);
897 // We also need the native variant of the check (for DOM types). 897 // We also need the native variant of the check (for DOM types).
898 helper = getNativeCheckedModeHelper(type, typeCast: true); 898 helper = getNativeCheckedModeHelper(type, typeCast: true);
899 if (helper != null) { 899 if (helper != null) {
900 enqueueInResolution(helper.getElement(compiler), elements); 900 enqueueInResolution(helper.getElement(compiler), elements);
901 } 901 }
902 } 902 }
903 903
904 void registerThrowNoSuchMethod(TreeElements elements) { 904 void registerThrowNoSuchMethod(TreeElements elements) {
905 enqueueInResolution(getThrowNoSuchMethod(), elements); 905 enqueueInResolution(getThrowNoSuchMethod(), elements);
906 compiler.enqueuer.resolution.registerInstantiatedClass(
ahe 2013/08/15 11:27:43 Please document that these represent the arguments
ngeoffray 2013/08/15 11:31:34 Done.
907 compiler.listClass, elements);
908 enqueuer.registerInstantiatedClass(compiler.stringClass, elements);
906 } 909 }
907 910
908 void registerThrowRuntimeError(TreeElements elements) { 911 void registerThrowRuntimeError(TreeElements elements) {
912 enqueuer.registerInstantiatedClass(compiler.stringClass, elements);
ahe 2013/08/15 11:27:43 Ditto.
ngeoffray 2013/08/15 11:31:34 Done.
909 enqueueInResolution(getThrowRuntimeError(), elements); 913 enqueueInResolution(getThrowRuntimeError(), elements);
910 } 914 }
911 915
912 void registerAbstractClassInstantiation(TreeElements elements) { 916 void registerAbstractClassInstantiation(TreeElements elements) {
917 enqueuer.registerInstantiatedClass(compiler.stringClass, elements);
ahe 2013/08/15 11:27:43 Ditto.
ngeoffray 2013/08/15 11:31:34 Done.
913 enqueueInResolution(getThrowAbstractClassInstantiationError(), elements); 918 enqueueInResolution(getThrowAbstractClassInstantiationError(), elements);
914 } 919 }
915 920
916 void registerFallThroughError(TreeElements elements) { 921 void registerFallThroughError(TreeElements elements) {
917 enqueueInResolution(getFallThroughError(), elements); 922 enqueueInResolution(getFallThroughError(), elements);
918 } 923 }
919 924
920 void registerSuperNoSuchMethod(TreeElements elements) { 925 void registerSuperNoSuchMethod(TreeElements elements) {
921 enqueueInResolution(getCreateInvocationMirror(), elements); 926 enqueueInResolution(getCreateInvocationMirror(), elements);
922 enqueueInResolution( 927 enqueueInResolution(
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 copy(constant.values); 1588 copy(constant.values);
1584 copy(constant.protoValue); 1589 copy(constant.protoValue);
1585 copy(constant); 1590 copy(constant);
1586 } 1591 }
1587 1592
1588 void visitConstructed(ConstructedConstant constant) { 1593 void visitConstructed(ConstructedConstant constant) {
1589 copy(constant.fields); 1594 copy(constant.fields);
1590 copy(constant); 1595 copy(constant);
1591 } 1596 }
1592 } 1597 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698