Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 228263008: Since we're not going to be treating "asset" as special soon, we don't need to yell at the user for… (Closed)

Created:
6 years, 8 months ago by Bob Nystrom
Modified:
6 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Since we're not going to be treating "asset" as special soon, we don't need to yell at the user for using it. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -213 lines) Patch
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +11 lines, -47 lines 0 comments Download
D sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
6 years, 8 months ago (2014-04-09 20:16:34 UTC) #1
nweiz
lgtm
6 years, 8 months ago (2014-04-09 20:51:21 UTC) #2
Bob Nystrom
6 years, 8 months ago (2014-04-10 18:27:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698