Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart

Issue 228263008: Since we're not going to be treating "asset" as special soon, we don't need to yell at the user for… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart b/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
deleted file mode 100644
index 3d16fd1b29b3bbf2be124c3e0b7b4621b054d3fd..0000000000000000000000000000000000000000
--- a/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
+++ /dev/null
@@ -1,87 +0,0 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library pub_tests;
-
-import 'package:path/path.dart' as path;
-import 'package:scheduled_test/scheduled_stream.dart';
-import 'package:scheduled_test/scheduled_test.dart';
-
-import '../descriptor.dart' as d;
-import '../test_pub.dart';
-import 'utils.dart';
-
-main() {
- initConfig();
- integration('warns user about top-level "assets" directories', () {
- d.dir(appPath, [
- d.appPubspec(),
- d.dir('bin', [
- d.dir('assets')
- ]),
- d.dir('test', [
- d.dir('assets')
- ]),
- d.dir('web', [
- d.file('index.html'),
- d.dir('assets')
- ])
- ]).create();
-
- var pub = pubServe();
- waitForBuildSuccess();
-
- pub.stderr.expect(emitsLines('''
-Warning: Pub reserves paths containing "assets" for using assets from packages.
-Please rename the directory "${path.join('bin', 'assets')}".
-Please rename the directory "${path.join('test', 'assets')}".
-Please rename the directory "${path.join('web', 'assets')}".'''));
- endPubServe();
- });
-
- integration('warns user about top-level "assets" files', () {
- d.dir(appPath, [
- d.appPubspec(),
- d.dir('bin', [
- d.file('assets', '...')
- ]),
- d.dir('test', [
- d.file('assets', '...')
- ]),
- d.dir('web', [
- d.file('index.html'),
- d.file('assets', '...')
- ])
- ]).create();
-
- var pub = pubServe();
- waitForBuildSuccess();
- pub.stderr.expect(emitsLines('''
-Warning: Pub reserves paths containing "assets" for using assets from packages.
-Please rename the file "${path.join('bin', 'assets')}".
-Please rename the file "${path.join('test', 'assets')}".
-Please rename the file "${path.join('web', 'assets')}".'''));
- endPubServe();
- });
-
- integration('does not warn on "assets" in subdirectories', () {
- d.dir(appPath, [
- d.appPubspec(),
- d.dir('web', [
- d.file('index.html'),
- d.dir('foo', [
- d.dir('assets')
- ]),
- d.dir('bar', [
- d.file('assets', '...')
- ])
- ])
- ]).create();
-
- var pub = pubServe();
- waitForBuildSuccess();
- endPubServe();
- pub.stderr.expect(never(contains("Warning")));
- });
-}
« no previous file with comments | « sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698