Issue 228093003: Make File:openRead always have one outstanding read, when invoking callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228093003: Make File:openRead always have one outstanding read, when invoking callbacks. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make File:openRead always have one outstanding read, when invoking callbacks. This sligly improves latency for reading. Note that pause/resume is less precise now, but it was never a guarantee exactly _when_ pausing would take place. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34814

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	sdk/lib/io/file_impl.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	tests/standalone/io/file_input_stream_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

This CL depends on https://codereview.chromium.org//227733002.

6 years, 8 months ago (2014-04-08 07:17:40 UTC) #1

Anders Johnsen

6 years, 8 months ago (2014-04-08 08:58:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34814 (presubmit successful).

Expand Messages | Collapse Messages