Issue 227733002: Don't call read, if last read returned less bytes than was being read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227733002: Don't call read, if last read returned less bytes than was being read. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't call read, if last read returned less bytes than was being read. This speeds up File.openRead, especially for small files. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34813

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -66 lines)			Patch
	M	sdk/lib/io/file_impl.dart	View		5 chunks	+58 lines, -66 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

6 years, 8 months ago (2014-04-08 08:47:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34813 (presubmit successful).