Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2276943003: Improve circular dependency overrides. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve circular dependency overrides. When a dependency is overridden, any dependency it has back on the root package is now ignored. This makes it easier for users to develop one portion of a circular dependency. Closes #1443 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/fdf7b48746f225544f2aba802d48813cd61947c1

Patch Set 1 #

Patch Set 2 : Fix a bug. #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M lib/src/solver/backtracking_solver.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M test/version_solver_test.dart View 1 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 4 months ago (2016-08-24 20:56:22 UTC) #1
Bob Nystrom
LGTM. https://codereview.chromium.org/2276943003/diff/20001/lib/src/solver/backtracking_solver.dart File lib/src/solver/backtracking_solver.dart (right): https://codereview.chromium.org/2276943003/diff/20001/lib/src/solver/backtracking_solver.dart#newcode583 lib/src/solver/backtracking_solver.dart:583: // If an overridden dependencies depends on the ...
4 years, 4 months ago (2016-08-25 00:30:02 UTC) #2
nweiz
Code review changes
4 years, 4 months ago (2016-08-25 00:30:56 UTC) #3
nweiz
https://codereview.chromium.org/2276943003/diff/20001/lib/src/solver/backtracking_solver.dart File lib/src/solver/backtracking_solver.dart (right): https://codereview.chromium.org/2276943003/diff/20001/lib/src/solver/backtracking_solver.dart#newcode583 lib/src/solver/backtracking_solver.dart:583: // If an overridden dependencies depends on the root ...
4 years, 4 months ago (2016-08-25 00:31:02 UTC) #4
nweiz
4 years, 4 months ago (2016-08-25 00:31:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fdf7b48746f225544f2aba802d48813cd61947c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698