Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: test/version_solver_test.dart

Issue 2276943003: Improve circular dependency overrides. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/version_solver_test.dart
diff --git a/test/version_solver_test.dart b/test/version_solver_test.dart
index e0a1eeaddf85dbfe73bff444efab682a3ad77aaf..fd67fbd9236b7721d226f71e2acb27ccbd6c5686 100644
--- a/test/version_solver_test.dart
+++ b/test/version_solver_test.dart
@@ -1216,7 +1216,7 @@ void override() {
'- myapp depends on version >=1.0.0 <2.0.0');
});
- integration('override a bad source without error', () {
+ integration('overrides a bad source without error', () {
servePackages((builder) {
builder.serve('foo', '0.0.0');
});
@@ -1231,6 +1231,22 @@ void override() {
expectResolves(result: {'foo': '0.0.0'});
});
+
+ integration('overrides an unmatched root dependency', () {
+ servePackages((builder) {
+ builder.serve('foo', '0.0.0', deps: {'myapp': '1.0.0'});
+ });
+
+ d.dir(appPath, [
+ d.pubspec({
+ 'name': 'myapp',
+ 'version': '2.0.0',
+ 'dependency_overrides': {'foo': 'any'}
+ })
+ ]).create();
+
+ expectResolves(result: {'foo': '0.0.0'});
+ });
}
void downgrade() {
« no previous file with comments | « lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698