Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2272223003: Stop JSON-encoding cross-frame messages. (Closed)

Created:
4 years, 3 months ago by nweiz
Modified:
4 years, 3 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop JSON-encoding cross-frame messages. The Dartium versions that didn't support this are long since out of circulation. R=jakemac@google.com Committed: https://github.com/dart-lang/test/commit/422c4fc094c8a44eac623f24d0fff441bb30a132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1640 lines, -1244 lines) Patch
M lib/src/runner/browser/post_message_channel.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/runner/browser/static/host.dart View 2 chunks +1 line, -6 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js View 322 chunks +1637 lines, -1235 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 3 months ago (2016-08-25 00:30:24 UTC) #1
jakemac
lgtm
4 years, 3 months ago (2016-08-25 14:19:14 UTC) #2
nweiz
4 years, 3 months ago (2016-08-25 20:20:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
422c4fc094c8a44eac623f24d0fff441bb30a132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698