Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: lib/src/runner/browser/post_message_channel.dart

Issue 2272223003: Stop JSON-encoding cross-frame messages. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/src/runner/browser/static/host.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:convert'; 5 import 'dart:convert';
6 import 'dart:html'; 6 import 'dart:html';
7 7
8 import 'package:stream_channel/stream_channel.dart'; 8 import 'package:stream_channel/stream_channel.dart';
9 9
10 /// Constructs a [StreamChannel] wrapping `postMessage` communication with the 10 /// Constructs a [StreamChannel] wrapping `postMessage` communication with the
11 /// host page. 11 /// host page.
12 StreamChannel postMessageChannel() { 12 StreamChannel postMessageChannel() {
13 var controller = new StreamChannelController(sync: true); 13 var controller = new StreamChannelController(sync: true);
14 14
15 window.onMessage.listen((message) { 15 window.onMessage.listen((message) {
16 // A message on the Window can theoretically come from any website. It's 16 // A message on the Window can theoretically come from any website. It's
17 // very unlikely that a malicious site would care about hacking someone's 17 // very unlikely that a malicious site would care about hacking someone's
18 // unit tests, let alone be able to find the test server while it's 18 // unit tests, let alone be able to find the test server while it's
19 // running, but it's good practice to check the origin anyway. 19 // running, but it's good practice to check the origin anyway.
20 if (message.origin != window.location.origin) return; 20 if (message.origin != window.location.origin) return;
21 message.stopPropagation(); 21 message.stopPropagation();
22 22
23 // See host.dart for why we have to explicitly decode here. 23 controller.local.sink.add(message.data);
24 controller.local.sink.add(JSON.decode(message.data));
25 }); 24 });
26 25
27 controller.local.stream.listen((data) { 26 controller.local.stream.listen((data) {
28 // TODO(nweiz): Stop manually adding href here once issue 22554 is 27 // TODO(nweiz): Stop manually adding href here once issue 22554 is
29 // fixed. 28 // fixed.
30 window.parent.postMessage({ 29 window.parent.postMessage({
31 "href": window.location.href, 30 "href": window.location.href,
32 "data": data 31 "data": data
33 }, window.location.origin); 32 }, window.location.origin);
34 }); 33 });
35 34
36 // Send a ready message once we're listening so the host knows it's safe to 35 // Send a ready message once we're listening so the host knows it's safe to
37 // start sending events. 36 // start sending events.
38 window.parent.postMessage({ 37 window.parent.postMessage({
39 "href": window.location.href, 38 "href": window.location.href,
40 "ready": true 39 "ready": true
41 }, window.location.origin); 40 }, window.location.origin);
42 41
43 return controller.foreign; 42 return controller.foreign;
44 } 43 }
OLDNEW
« no previous file with comments | « no previous file | lib/src/runner/browser/static/host.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698